Close the last findings of the sixth review - #72
Merged
Conversation
The completion handler stopped offering object properties the moment a character was typed after the dot. ExtractObjectPath required the line to end with one, and the editor re-requests completion on every keystroke — so the list appeared after "Server." and vanished at "Server.P", exactly when it becomes useful. The identifier being typed is now stripped before looking for the dot; filtering it was already handled separately. This is the behaviour the previous round could not characterise and removed a test for rather than guess at. The answer was that it did not work. Four invariants that mutation testing showed nothing protected now have tests: short-circuit evaluation of and/or, which is written and commented but was only observable when the right side would fail; duplicate let detection, a deliberate validation with a user-facing message and no test anywhere; LF normalisation of generated files, which would churn every diff on every platform; and case-insensitive comparison of flattened array entries, which would otherwise report a field as leaking when the override does redefine it in different casing. Three documentation claims corrected against what the compiler does: output goes to the current directory, not next to the source; commas are optional only across newlines, since two items on one line still need one; and the specification's "exactly one settings block" has been wrong since multiple blocks began to deep-merge, which is what lets an included file contribute one. 409 -> 415 tests. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Les trois derniers points de la sixième revue.
Le comportement que je n'avais pas su caractériser
La complétion cessait d'offrir les propriétés d'un objet dès qu'on tapait un caractère après le point.
ExtractObjectPathexigeait que la ligne se termine par un point, et l'éditeur relance la requête à chaque frappe : la liste apparaissait aprèsServer.et disparaissait àServer.P— précisément quand elle devient utile.L'identifiant en cours de frappe est maintenant retiré avant de chercher le point ; le filtrage était déjà géré à part.
La réponse à la question du tour précédent était donc : ça ne marchait pas. J'avais supprimé le test plutôt que de deviner ; il est de retour, et il vérifie les deux choses — la propriété est offerte, et la liste est réduite à ce qui correspond.
Quatre invariants que rien ne protégeait
Le test par mutation les avait signalés :
and/orletdupliquésTrois affirmations documentaires fausses
settings» — faux depuis que plusieurs blocs fusionnent en profondeur, ce qui est justement ce qui permet à un fichier inclus d'en contribuer un.409 → 415 tests.
🤖 Generated with Claude Code